Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Reply-To: hdfs-issues@hadoop.apache.org
Date: Mon, 11 Mar 2013 22:29:14 +0000 (UTC)
From: "Chris Nauroth (JIRA)" <jira@apache.org>
To: hdfs-issues@hadoop.apache.org
Message-ID: <JIRA.12636444.1363034302698.421585.1363040954214@arcas>
In-Reply-To: <JIRA.12636444.1363034302698@arcas>
References: <JIRA.12636444.1363034302698@arcas>
Subject: [jira] [Commented] (HDFS-4586) TestDataDirs.testGetDataDirsFromURIs
 fails with all directories in dfs.datanode.data.dir are invalid
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HDFS-4586?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13599404#comment-13599404 ] 

Chris Nauroth commented on HDFS-4586:
-------------------------------------

I really appreciate you picking up this fix so quickly.  :-)

{code}
    public DataNodeDiskChecker(FsPermission expectedPermission) {
    }
{code}

It looks like the constructor forgot to initialize expectedPermission.  I added {{this.expectedPermission = expectedPermission;}} before I tested the patch.  I verified that it was successful on both Mac and Windows.

If you can upload a new patch with that small change, then I am +1.  I agree with the approach.

Thanks again!

                
> TestDataDirs.testGetDataDirsFromURIs fails with all directories in dfs.datanode.data.dir are invalid
> ----------------------------------------------------------------------------------------------------
>
>                 Key: HDFS-4586
>                 URL: https://issues.apache.org/jira/browse/HDFS-4586
>             Project: Hadoop HDFS
>          Issue Type: Bug
>    Affects Versions: 3.0.0
>            Reporter: Ivan Mitic
>            Assignee: Ivan Mitic
>         Attachments: HDFS-4586.trunk.patch
>
>
> Error Message
> All directories in dfs.datanode.data.dir are invalid: "/p1" "/p2" "/p3" 
>  Stacktrace
> {code}
> java.io.IOException: All directories in dfs.datanode.data.dir are invalid: "/p1" "/p2" "/p3" 
> 	at org.apache.hadoop.hdfs.server.datanode.DataNode.getDataDirsFromURIs(DataNode.java:1668)
> 	at org.apache.hadoop.hdfs.server.datanode.TestDataDirs.testGetDataDirsFromURIs(TestDataDirs.java:53)
> 	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> {code}
> Seems like Jenkins will return -1 on all HDFS patches because of this (check HDFS-4583)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira