Return-Path: X-Original-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 47A0A9207 for ; Mon, 4 Mar 2013 18:39:13 +0000 (UTC) Received: (qmail 37685 invoked by uid 500); 4 Mar 2013 18:39:12 -0000 Delivered-To: apmail-hadoop-hdfs-issues-archive@hadoop.apache.org Received: (qmail 37633 invoked by uid 500); 4 Mar 2013 18:39:12 -0000 Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: hdfs-issues@hadoop.apache.org Delivered-To: mailing list hdfs-issues@hadoop.apache.org Received: (qmail 37624 invoked by uid 99); 4 Mar 2013 18:39:12 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 04 Mar 2013 18:39:12 +0000 Date: Mon, 4 Mar 2013 18:39:12 +0000 (UTC) From: "Suresh Srinivas (JIRA)" To: hdfs-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HDFS-4544) Error in deleting blocks should not do check disk, for all types of errors MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HDFS-4544?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13592469#comment-13592469 ] Suresh Srinivas commented on HDFS-4544: --------------------------------------- +1. This seems like a good change. > Error in deleting blocks should not do check disk, for all types of errors > -------------------------------------------------------------------------- > > Key: HDFS-4544 > URL: https://issues.apache.org/jira/browse/HDFS-4544 > Project: Hadoop HDFS > Issue Type: Bug > Affects Versions: 1.1.1 > Reporter: Amareshwari Sriramadasu > Fix For: 1.2.0 > > > The following code in Datanode.java > {noformat} > try { > if (blockScanner != null) { > blockScanner.deleteBlocks(toDelete); > } > data.invalidate(toDelete); > } catch(IOException e) { > checkDiskError(); > throw e; > } > {noformat} > causes check disk to happen in case of any errors during invalidate. > We have seen errors like : > 2013-03-02 00:08:28,849 WARN org.apache.hadoop.hdfs.server.datanode.DataNode: Unexpected error trying to delete block blk_-2973118207682441648_225738165. BlockInfo not found in volumeMap. > And all such errors trigger check disk, making the clients timeout. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira