hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Chris Nauroth (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-4651) Offline Image Viewer backport to branch-1
Date Sat, 30 Mar 2013 18:13:15 GMT

    [ https://issues.apache.org/jira/browse/HDFS-4651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13618128#comment-13618128
] 

Chris Nauroth commented on HDFS-4651:
-------------------------------------

It looks like oiv only used Guava for one thing: a convenient constant definition of a charset
in {{TextWriterImageVisitor}}:

{code}
public TextWriterImageVisitor(String filename, boolean printToScreen)
       throws IOException {
  super();
  this.printToScreen = printToScreen;
  fw = new OutputStreamWriter(new FileOutputStream(filename), Charsets.UTF_8);
  okToWrite = true;
}
{code}

If the Guava dependency is problematic, then it would be easy to inline this constant definition,
which is just {{java.nio.charset.Charset.forName("UTF-8")}}.

https://code.google.com/p/guava-libraries/source/browse/guava/src/com/google/common/base/Charsets.java#56

                
> Offline Image Viewer backport to branch-1
> -----------------------------------------
>
>                 Key: HDFS-4651
>                 URL: https://issues.apache.org/jira/browse/HDFS-4651
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: tools
>    Affects Versions: 1.2.1
>            Reporter: Chris Nauroth
>            Assignee: Chris Nauroth
>         Attachments: fsimageV18, fsimageV19, HDFS-4651-branch-1.1.patch, HDFS-4651-branch-1.2.patch
>
>
> This issue tracks backporting the Offline Image Viewer tool to branch-1.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message