hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Colin Patrick McCabe (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-4640) JniBasedUnixGroupsMapping: fix some crash bugs
Date Tue, 26 Mar 2013 22:57:15 GMT

    [ https://issues.apache.org/jira/browse/HDFS-4640?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13614645#comment-13614645
] 

Colin Patrick McCabe commented on HDFS-4640:
--------------------------------------------

I should explain the error path comment a bit.  When you have something like this:

{code}
if (error)
    goto done;
MyFoo *foo = NULL;
done:
    free(foo);
{code}

The compiler treats foo as uninitialized on the error path.  It is best to move the declarations
of stuff that gets freed at the end to the top to avoid this problem.
                
> JniBasedUnixGroupsMapping: fix some crash bugs
> ----------------------------------------------
>
>                 Key: HDFS-4640
>                 URL: https://issues.apache.org/jira/browse/HDFS-4640
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: security
>    Affects Versions: 2.0.5-beta
>            Reporter: Colin Patrick McCabe
>            Assignee: Colin Patrick McCabe
>            Priority: Minor
>         Attachments: HDFS-4640.001.patch
>
>
> JniBasedUnixGroupsMapping has some issues.
> * sometimes on error paths variables are freed prior to being initialized
> * re-allocate buffers less frequently (can reuse the same buffer for multiple calls to
getgrnam)
> * allow non-reentrant functions to be used, to work around client bugs
> * don't throw IOException from JNI functions if the JNI functions do not declare this
checked exception.
> * don't bail out if only one group name among all the ones associated with a user can't
be looked up.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message