hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-4557) Fix FSDirectory#delete when INode#cleanSubtree returns 0
Date Fri, 08 Mar 2013 13:14:16 GMT

    [ https://issues.apache.org/jira/browse/HDFS-4557?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13597109#comment-13597109
] 

Hudson commented on HDFS-4557:
------------------------------

Integrated in Hadoop-Hdfs-Snapshots-Branch-build #123 (See [https://builds.apache.org/job/Hadoop-Hdfs-Snapshots-Branch-build/123/])
    HDFS-4557. Fix FSDirectory#delete when INode#cleanSubtree returns 0.  Contributed by Jing
Zhao (Revision 1454138)

     Result = FAILURE
szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1454138
Files : 
* /hadoop/common/branches/HDFS-2802/hadoop-hdfs-project/hadoop-hdfs/CHANGES.HDFS-2802.txt
* /hadoop/common/branches/HDFS-2802/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirectory.java
* /hadoop/common/branches/HDFS-2802/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java
* /hadoop/common/branches/HDFS-2802/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/INodeFile.java
* /hadoop/common/branches/HDFS-2802/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/snapshot/AbstractINodeDiffList.java
* /hadoop/common/branches/HDFS-2802/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/snapshot/INodeFileUnderConstructionWithSnapshot.java
* /hadoop/common/branches/HDFS-2802/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/snapshot/INodeFileWithSnapshot.java

                
> Fix FSDirectory#delete when INode#cleanSubtree returns 0
> --------------------------------------------------------
>
>                 Key: HDFS-4557
>                 URL: https://issues.apache.org/jira/browse/HDFS-4557
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: namenode
>            Reporter: Jing Zhao
>            Assignee: Jing Zhao
>             Fix For: Snapshot (HDFS-2802)
>
>         Attachments: HDFS-4557.000.patch, HDFS-4557.001.patch, HDFS-4557.002.patch, HDFS-4557.003.patch,
HDFS-4557.003.patch
>
>
> Currently INode#cleanSubtree is used to delete files/directories and collect corresponding
blocks for future deletion. Its return value can be 0 even if file/dir has been deleted because
we save snapshot copies. This breaks the original logic in FSDirectory#delete since FSDirectory#delete
expects a positive value from a successful deletion.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message