hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jing Zhao (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-4534) Update rename for snapshots
Date Fri, 15 Mar 2013 01:51:11 GMT

    [ https://issues.apache.org/jira/browse/HDFS-4534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13603021#comment-13603021
] 

Jing Zhao commented on HDFS-4534:
---------------------------------

The new INodeReference looks pretty good. My thoughts about the current patch:
1. While deleting snapshots, we may have to handle INodeReference. Using the same example
in the javadoc of INodeReference: in /abc, if ref(1001, foo) is in the deleted list of the
very first diff, when we want to delete the correspond diff, the current code may destroy
the inode bar(1000) even if it is still referred by others? Simiarly scenarios if ref(1001,
foo) is processed by a Processor. We may need to check the reference number first and decide
if we need to destroy the referred INode (i.e., bar(1000)).

2. After the reference number is decrease to 0, we need to destroy the inode (bar(1000)) and
delete the reference node (ref(1003)).

3. In both unprotectedRename methods, seems that srcParent.asDirectory.replaceChild4Reference
only replaces the current child and the created list, and we need to replace the inode in
the deleted list?

Minor:
4. INodeReference.java, INodeReference#referenced can be renamed to INodeReference#referred
or some other name? Similarly update the javadoc of the class.
5. In javadoc of INodeReference, /abc will have a child ref(1001, foo) instead of ref(1001),
/xyz will have a child ref(1002) instead of ref(1002, bar)?
6. In INodeDirectory#replaceChild, can oldChild.getParentReference() return a non-null result?
7. WithName#setLocalName will not be called in normal cases?
                
> Update rename for snapshots
> ---------------------------
>
>                 Key: HDFS-4534
>                 URL: https://issues.apache.org/jira/browse/HDFS-4534
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: namenode
>            Reporter: Tsz Wo (Nicholas), SZE
>            Assignee: Tsz Wo (Nicholas), SZE
>         Attachments: h4534_20130307.patch, h4534_20130313.patch, h4534_20130314b.patch,
h4534_20130314c.patch, h4534_20130314.patch
>
>
> With rename, an inode may be moved from one location to another location in the namespace
tree.  We need to take care the case that the inode is also in some snapshots.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message