Return-Path: X-Original-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id E8D46EBA8 for ; Sun, 3 Feb 2013 17:46:13 +0000 (UTC) Received: (qmail 74455 invoked by uid 500); 3 Feb 2013 17:46:13 -0000 Delivered-To: apmail-hadoop-hdfs-issues-archive@hadoop.apache.org Received: (qmail 74411 invoked by uid 500); 3 Feb 2013 17:46:13 -0000 Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: hdfs-issues@hadoop.apache.org Delivered-To: mailing list hdfs-issues@hadoop.apache.org Received: (qmail 74402 invoked by uid 99); 3 Feb 2013 17:46:13 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 03 Feb 2013 17:46:13 +0000 Date: Sun, 3 Feb 2013 17:46:13 +0000 (UTC) From: "Hudson (JIRA)" To: hdfs-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HDFS-4445) All BKJM ledgers are not checked while tailing, So failover will fail. MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HDFS-4445?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13569825#comment-13569825 ] Hudson commented on HDFS-4445: ------------------------------ Integrated in Hadoop-trunk-Commit #3316 (See [https://builds.apache.org/job/Hadoop-trunk-Commit/3316/]) HDFS-4445. All BKJM ledgers are not checked while tailing, So failover will fail. Contributed Vinay. (Revision 1441935) Result = SUCCESS umamahesh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1441935 Files : * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/contrib/bkjournal/src/main/java/org/apache/hadoop/contrib/bkjournal/BookKeeperJournalManager.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/contrib/bkjournal/src/test/java/org/apache/hadoop/contrib/bkjournal/TestBookKeeperAsHASharedDir.java > All BKJM ledgers are not checked while tailing, So failover will fail. > ---------------------------------------------------------------------- > > Key: HDFS-4445 > URL: https://issues.apache.org/jira/browse/HDFS-4445 > Project: Hadoop HDFS > Issue Type: Sub-task > Affects Versions: 2.0.3-alpha > Reporter: Vinay > Assignee: Vinay > Priority: Blocker > Attachments: HDFS-4445.patch > > > After the fix of HDFS-4130, all editlog nodes are not iterated if first edit are below fromTxId > Problem part is below code inside BookKeeperJournalManager#selectInputStreams(..) > {code} if (fromTxId >= l.getFirstTxId() && fromTxId <= lastTxId) { > LedgerHandle h; > if (l.isInProgress()) { // we don't want to fence the current journal > h = bkc.openLedgerNoRecovery(l.getLedgerId(), digestType, > digestpw.getBytes()); > } else { > h = bkc > .openLedger(l.getLedgerId(), digestType, digestpw.getBytes()); > } > elis = new BookKeeperEditLogInputStream(h, l); > elis.skipTo(fromTxId); > } else { > return; > }{code} > The else block should have continue statement instead of return. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira