Return-Path: X-Original-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 26340DBC4 for ; Fri, 1 Feb 2013 22:20:16 +0000 (UTC) Received: (qmail 44368 invoked by uid 500); 1 Feb 2013 22:20:13 -0000 Delivered-To: apmail-hadoop-hdfs-issues-archive@hadoop.apache.org Received: (qmail 44315 invoked by uid 500); 1 Feb 2013 22:20:13 -0000 Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: hdfs-issues@hadoop.apache.org Delivered-To: mailing list hdfs-issues@hadoop.apache.org Received: (qmail 44266 invoked by uid 99); 1 Feb 2013 22:20:13 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 01 Feb 2013 22:20:13 +0000 Date: Fri, 1 Feb 2013 22:20:13 +0000 (UTC) From: "Thomas Graves (JIRA)" To: hdfs-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Updated] (HDFS-4444) Add space between total transaction time and number of transactions in FSEditLog#printStatistics MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HDFS-4444?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thomas Graves updated HDFS-4444: -------------------------------- Fix Version/s: 0.23.7 > Add space between total transaction time and number of transactions in FSEditLog#printStatistics > ------------------------------------------------------------------------------------------------ > > Key: HDFS-4444 > URL: https://issues.apache.org/jira/browse/HDFS-4444 > Project: Hadoop HDFS > Issue Type: Bug > Affects Versions: 2.0.0-alpha, 3.0.0 > Reporter: Stephen Chu > Assignee: Stephen Chu > Priority: Trivial > Fix For: 1.2.0, 2.0.3-alpha, 0.23.7 > > Attachments: HDFS-4444.patch.001, HDFS-4444.patch.branch-1 > > > Currently, when we log statistics, we see something like > {code} > 13/01/25 23:16:59 INFO namenode.FSNamesystem: Number of transactions: 0 Total time for transactions(ms): 0Number of transactions batched in Syncs: 0 Number of syncs: 0 SyncTimes(ms): 0 > {code} > Notice how the value for total transactions time and "Number of transactions batched in Syncs" needs a space to separate them. > FSEditLog#printStatistics: > {code} > private void printStatistics(boolean force) { > long now = now(); > if (lastPrintTime + 60000 > now && !force) { > return; > } > lastPrintTime = now; > StringBuilder buf = new StringBuilder(); > buf.append("Number of transactions: "); > buf.append(numTransactions); > buf.append(" Total time for transactions(ms): "); > buf.append(totalTimeTransactions); > buf.append("Number of transactions batched in Syncs: "); > buf.append(numTransactionsBatchedInSync); > buf.append(" Number of syncs: "); > buf.append(editLogStream.getNumSync()); > buf.append(" SyncTimes(ms): "); > buf.append(journalSet.getSyncTimes()); > LOG.info(buf); > } > {code} -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira