Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Reply-To: hdfs-issues@hadoop.apache.org
Date: Sat, 23 Feb 2013 02:36:13 +0000 (UTC)
From: "Hadoop QA (JIRA)" <jira@apache.org>
To: hdfs-issues@hadoop.apache.org
Message-ID: <JIRA.12618101.1354152061260.327024.1361586973254@arcas>
In-Reply-To: <JIRA.12618101.1354152061260@arcas>
References: <JIRA.12618101.1354152061260@arcas>
Subject: [jira] [Commented] (HDFS-4235) when outputting XML,
 OfflineEditsViewer can't handle some edits containing non-ASCII strings
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable


    [ https://issues.apache.org/jira/browse/HDFS-4235?page=3Dcom.atlassian.=
jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D13584=
964#comment-13584964 ]=20

Hadoop QA commented on HDFS-4235:
---------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest a=
ttachment=20
  http://issues.apache.org/jira/secure/attachment/12570577/HDFS-4235.002.pa=
tch
  against trunk revision .

    {color:green}+1 @author{color}.  The patch does not contain any @author=
 tags.

    {color:green}+1 tests included{color}.  The patch appears to include 2 =
new or modified test files.

  {color:red}-1 one of tests included doesn't have a timeout.{color}

    {color:green}+1 javac{color}.  The applied patch does not increase the =
total number of javac compiler warnings.

    {color:green}+1 javadoc{color}.  The javadoc tool did not generate any =
warning messages.

    {color:green}+1 eclipse:eclipse{color}.  The patch built with eclipse:e=
clipse.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new =
Findbugs (version 1.3.9) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not incre=
ase the total number of release audit warnings.

    {color:green}+1 core tests{color}.  The patch passed unit tests in hado=
op-hdfs-project/hadoop-hdfs.

    {color:green}+1 contrib tests{color}.  The patch passed contrib unit te=
sts.

Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/3999//test=
Report/
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/3999//co=
nsole

This message is automatically generated.
               =20
> when outputting XML, OfflineEditsViewer can't handle some edits containin=
g non-ASCII strings
> -------------------------------------------------------------------------=
-------------------
>
>                 Key: HDFS-4235
>                 URL: https://issues.apache.org/jira/browse/HDFS-4235
>             Project: Hadoop HDFS
>          Issue Type: Bug
>    Affects Versions: 2.0.3-alpha
>            Reporter: Colin Patrick McCabe
>            Assignee: Colin Patrick McCabe
>            Priority: Minor
>         Attachments: HDFS-4235.001.patch, HDFS-4235.002.patch, HDFS-4235.=
003.patch
>
>
> It seems that when outputting XML, OfflineEditsViewer can't handle some e=
dits containing non-ASCII strings.
> Example:
> {code}
> cmccabe@keter:/h> ./bin/hdfs oev -i ~/Downloads/current2/edits -o /tmp/u.=
xml                                        =20
> 17:11:24,662 ERROR OfflineEditsBinaryLoader:82 - Got IOException at posit=
ion 10593
> Encountered exception. Exiting: SAX error: The character '=EF=BF=BD' is a=
n invalid XML character
> java.io.IOException: SAX error: The character '=EF=BF=BD' is an invalid X=
ML character
>         at org.apache.hadoop.hdfs.tools.offlineEditsViewer.XmlEditsVisito=
r.visitOp(XmlEditsVisitor.java:119)
>         at org.apache.hadoop.hdfs.tools.offlineEditsViewer.OfflineEditsBi=
naryLoader.loadEdits(OfflineEditsBinaryLoader.java:78)
>         at org.apache.hadoop.hdfs.tools.offlineEditsViewer.OfflineEditsVi=
ewer.go(OfflineEditsViewer.java:142)
>         at org.apache.hadoop.hdfs.tools.offlineEditsViewer.OfflineEditsVi=
ewer.run(OfflineEditsViewer.java:228)
>         at org.apache.hadoop.util.ToolRunner.run(ToolRunner.java:70)
>         at org.apache.hadoop.util.ToolRunner.run(ToolRunner.java:84)
>         at org.apache.hadoop.hdfs.tools.offlineEditsViewer.OfflineEditsVi=
ewer.main(OfflineEditsViewer.java:237)
> {code}
> Probably, we forgot to properly escape and/or re-encode a filename before=
 putting it into the XML.  The other processors (stats, binary) don't have =
this problem, so it is purely an XML encoding issue.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrato=
rs
For more information on JIRA, see: http://www.atlassian.com/software/jira