hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-4530) return buffer into direct bufferPool in BlockReaderLocal as possible
Date Tue, 26 Feb 2013 05:56:16 GMT

    [ https://issues.apache.org/jira/browse/HDFS-4530?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13586820#comment-13586820

Hadoop QA commented on HDFS-4530:

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  against trunk revision .

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include any new or modified
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of
javac compiler warnings.

    {color:green}+1 javadoc{color}.  The javadoc tool did not generate any warning messages.

    {color:green}+1 eclipse:eclipse{color}.  The patch built with eclipse:eclipse.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new Findbugs (version
1.3.9) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number
of release audit warnings.

    {color:red}-1 core tests{color}.  The patch failed these unit tests in hadoop-hdfs-project/hadoop-hdfs:


    {color:green}+1 contrib tests{color}.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/4003//testReport/
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/4003//console

This message is automatically generated.
> return buffer into direct bufferPool in BlockReaderLocal as possible
> --------------------------------------------------------------------
>                 Key: HDFS-4530
>                 URL: https://issues.apache.org/jira/browse/HDFS-4530
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: datanode
>    Affects Versions: 3.0.0
>            Reporter: Liang Xie
>            Assignee: Liang Xie
>         Attachments: HDFS-4530.txt
> {code}
>   public synchronized void close() throws IOException {
>     dataIn.close();
>     if (checksumIn != null) {
>       checksumIn.close();
>     }
>     if (slowReadBuff != null) {
>       bufferPool.returnBuffer(slowReadBuff);
>       slowReadBuff = null;
>     }
>     if (checksumBuff != null) {
>       bufferPool.returnBuffer(checksumBuff);
>       checksumBuff = null;
>     }
>     startOffset = -1;
>     checksum = null;
>   }
> {code}
> If there's an IOException occurred in dataIn.close(), then the slowReadBuff&checksumBuff
could not be returned anymore.  let's make a trivial change to reduce this risk.

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

View raw message