hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-4526) If persistBlocks enabled in Namenode, hflush call can avoid persisting blocks with fsync
Date Thu, 28 Feb 2013 20:47:12 GMT

    [ https://issues.apache.org/jira/browse/HDFS-4526?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13589904#comment-13589904

Hadoop QA commented on HDFS-4526:

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  against trunk revision .

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include any new or modified
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of
javac compiler warnings.

    {color:green}+1 javadoc{color}.  The javadoc tool did not generate any warning messages.

    {color:green}+1 eclipse:eclipse{color}.  The patch built with eclipse:eclipse.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new Findbugs (version
1.3.9) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number
of release audit warnings.

    {color:green}+1 core tests{color}.  The patch passed unit tests in hadoop-hdfs-project/hadoop-hdfs.

    {color:green}+1 contrib tests{color}.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/4017//testReport/
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/4017//console

This message is automatically generated.
> If persistBlocks enabled in Namenode, hflush call can avoid persisting blocks with fsync
> ----------------------------------------------------------------------------------------
>                 Key: HDFS-4526
>                 URL: https://issues.apache.org/jira/browse/HDFS-4526
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: namenode
>    Affects Versions: 3.0.0, 2.0.3-alpha
>            Reporter: Uma Maheswara Rao G
>            Assignee: Uma Maheswara Rao G
>         Attachments: HDFS-4526.patch
> If persists blocks enabled/in HA, evenry getAdditionalBlock will persist the blocks.
> So, if user calls Hflush, then client can simply ensure data flushed to DNs and need
not worry about fsync. 
> Since we can not depend upon client side configuration about persistBlocks, we can just
make a fsync call to NN and check whether persistBlocks enabled. If it is enabled, then simply
return as it would have already persisted. So, that below peice of code execution can be avoided
for every blocks and hflush calls
> from fsync:
> {code}
>  writeLock();
>     try {
>       checkOperation(OperationCategory.WRITE);
>       if (isInSafeMode()) {
>         throw new SafeModeException("Cannot fsync file " + src, safeMode);
>       }
>       INodeFileUnderConstruction pendingFile  = checkLease(src, clientName);
>       dir.persistBlocks(src, pendingFile);
>     } finally {
>       writeUnlock();
>     }
>     getEditLog().logSync();
> {code}

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

View raw message