hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jing Zhao (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-4503) Update computeContentSummary, spaceConsumedInTree and diskspaceConsumed for snapshot
Date Tue, 19 Feb 2013 19:51:13 GMT

    [ https://issues.apache.org/jira/browse/HDFS-4503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13581563#comment-13581563

Jing Zhao commented on HDFS-4503:

Some thoughts about the current patch:
1. Currently when finalizing an INodeFileUnderConstruction, we call BlockManager#checkReplication,
which uses getBlockReplication to compute the expected replication factor. This expected will
thus be the highest replication factor in history among all snapshots. In that case, I think
maybe the current diskspaceConsumed function can be simplified (no need to calculate block
by block). And we may no longer need a class DiskSpaceConsumed for the calculation. 

2. When updating an INodeFile, after replacing the INodeFile with an INodeFileWithSnapshot,
we may need to update the blocksMap.

3. For INodeDirectorySnapshottable#addSanpshot and replaceSelf, we can add javadoc to explain
where QuotaExceededException may be thrown.

4. The class MultiCounts may be renamed to CountsMap?

> Update computeContentSummary, spaceConsumedInTree and diskspaceConsumed for snapshot
> ------------------------------------------------------------------------------------
>                 Key: HDFS-4503
>                 URL: https://issues.apache.org/jira/browse/HDFS-4503
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: namenode
>            Reporter: Tsz Wo (Nicholas), SZE
>            Assignee: Tsz Wo (Nicholas), SZE
>         Attachments: h4503_20130214.patch, h4503_20130215.patch, h4503_20130216.patch,
> There are three methods computeContentSummary, spaceConsumedInTree and diskspaceConsumed
for computing namespace/diskspace usages.  They need to be updated to the snapshot feature.

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

View raw message