hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-4492) NameNodeConnector should prevent other balancers to run while the one is running
Date Tue, 12 Feb 2013 20:07:13 GMT

    [ https://issues.apache.org/jira/browse/HDFS-4492?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13576961#comment-13576961

Hadoop QA commented on HDFS-4492:

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  against trunk revision .

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include any new or modified
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of
javac compiler warnings.

    {color:green}+1 javadoc{color}.  The javadoc tool did not generate any warning messages.

    {color:green}+1 eclipse:eclipse{color}.  The patch built with eclipse:eclipse.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new Findbugs (version
1.3.9) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number
of release audit warnings.

    {color:green}+1 core tests{color}.  The patch passed unit tests in hadoop-hdfs-project/hadoop-hdfs.

    {color:green}+1 contrib tests{color}.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/3966//testReport/
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/3966//console

This message is automatically generated.
> NameNodeConnector should prevent other balancers to run while the one is running
> --------------------------------------------------------------------------------
>                 Key: HDFS-4492
>                 URL: https://issues.apache.org/jira/browse/HDFS-4492
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: balancer
>    Affects Versions: 2.0.2-alpha
>            Reporter: Chu Tong
>            Priority: Minor
>         Attachments: HDFS-4492.patch
> In hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/balancer/NameNodeConnector.java:
> private OutputStream checkAndMarkRunningBalancer() throws IOException {
>     try {
>       final DataOutputStream out = fs.create(BALANCER_ID_PATH);
>       out.writeBytes(InetAddress.getLocalHost().getHostName());
>       out.flush();
>       return out;
>     } catch(RemoteException e) {
> ...
> In the code, fs.create should set overwrite bit to false so that other balancer can't
run while one is running.

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

View raw message