hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tsz Wo (Nicholas), SZE (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-4487) Fix snapshot diff report
Date Thu, 14 Feb 2013 02:26:12 GMT

    [ https://issues.apache.org/jira/browse/HDFS-4487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13578107#comment-13578107
] 

Tsz Wo (Nicholas), SZE commented on HDFS-4487:
----------------------------------------------

- In AbstractINodeDiffList, since size >= 0, if -earlierDiffIndex - 1 == size, we have
earlierDiffIndex <= -1.  So "earlierDiffIndex < 0" can be removed.

- Change Snapshot.ID_COMPARATOR so that null >= s for any snapshot s so that it is consistent
with using null to represent current state.

- Use List<byte[]> for DiffReportEntry.fullPath.  Then, we don't have to convert the
byte[] to string and further convert it back to byte[].



                
> Fix snapshot diff report
> ------------------------
>
>                 Key: HDFS-4487
>                 URL: https://issues.apache.org/jira/browse/HDFS-4487
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: namenode
>            Reporter: Tsz Wo (Nicholas), SZE
>            Assignee: Jing Zhao
>         Attachments: HDFS-4487.000.patch, HDFS-4487.001.patch, HDFS-4487.001.patch
>
>
> Diff report computation needs to be updated to support file diff.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message