hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Chris Nauroth (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-4468) Fix test failure for HADOOP-9252
Date Tue, 05 Feb 2013 22:33:14 GMT

    [ https://issues.apache.org/jira/browse/HDFS-4468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13571815#comment-13571815

Chris Nauroth commented on HDFS-4468:

Hi, Nicholas.  The changes look good.  Just one question on {{DatanodeInfo}}:

-    buffer.append("DFS Used%: "+StringUtils.limitDecimalTo2(usedPercent)+"%\n");
-    buffer.append("DFS Remaining%: "+StringUtils.limitDecimalTo2(remainingPercent)+"%\n");
+    buffer.append("DFS Used%: "+DFSUtil.percent2String(usedPercent));
+    buffer.append("DFS Remaining%: "+DFSUtil.percent2String(remainingPercent));

The old version would have appended newlines, but the new version doesn't.  Do we need to
add the newlines back into this patch?

> Fix test failure for HADOOP-9252
> --------------------------------
>                 Key: HDFS-4468
>                 URL: https://issues.apache.org/jira/browse/HDFS-4468
>             Project: Hadoop HDFS
>          Issue Type: Bug
>            Reporter: Tsz Wo (Nicholas), SZE
>            Assignee: Tsz Wo (Nicholas), SZE
>            Priority: Minor
>         Attachments: h4468_20130205.patch
> HADOOP-9252 slightly changes the format of some StringUtils outputs.  It may cause test
> Also, some methods were deprecated by HADOOP-9252.  The use of them should be replaced
with the new methods.

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

View raw message