hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Suresh Srinivas (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-4414) Create a DiffReport class to represent the diff between snapshots to end users
Date Sat, 02 Feb 2013 20:22:13 GMT

    [ https://issues.apache.org/jira/browse/HDFS-4414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13569634#comment-13569634
] 

Suresh Srinivas commented on HDFS-4414:
---------------------------------------

Comments:
# Remove unnecessary import change in DFSClient.java
# In DFSClient.java and DistributedFileSystem.java point to the documentation in ClientProtocol#getSnapshotDiffReport()
method, instead of repeating the same javadoc.
# ClientProtocol.java - Methods getSnapshotDiffReport, allowSnapshot, and disallowSnapshot
should document the specific expections thrown by the method and the condition in which they
are thrown. This is unrelated to the change in this patch and can be done as a separate jira.
# SnapshotDiffReport class should in o.a.h.protocol package.
# INodeDirectoryWithSnapshot - javadoc typo fromEarlierSnapshot -> fromEarlier
# SnapshotDiffReport.java - lineSepearator could be static final variable
# We should create another jira to conver the current implementation into iterative report.
Otherwise dealing with large set of changes in a single response will result in issues. This
should work similar to iterative ls operation.

+1 with these changes.
                
> Create a DiffReport class to represent the diff between snapshots to end users
> ------------------------------------------------------------------------------
>
>                 Key: HDFS-4414
>                 URL: https://issues.apache.org/jira/browse/HDFS-4414
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: datanode, namenode
>            Reporter: Jing Zhao
>            Assignee: Jing Zhao
>         Attachments: HDFS-4414.001.patch, HDFS-4414.003.patch, HDFS-4414.004.patch, HDFS-4414+4131.002.patch
>
>
> HDFS-4131 computes the difference between two snapshots (or between a snapshot and the
current tree). In this jira we create a DiffReport class to represent the diff to end users.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message