hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Brandon Li (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (HDFS-4340) Update addBlock() to inculde inode id as additional argument
Date Tue, 05 Feb 2013 21:47:13 GMT

     [ https://issues.apache.org/jira/browse/HDFS-4340?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Brandon Li updated HDFS-4340:
-----------------------------

    Attachment: HDFS-4340.patch

{quote}
    Please mention in ClientProtocol#createFile, the returned HdfsFileStatus could be null,
if the server does not return file status.{quote}
done.
{quote}Please mention in FSNamesystem#startFile() - returned HdfsFileStatus is always non
null. Why are we again parsing the path in this method to get the file info? Can we avoid
this by having an implementation that returns LocatedBlock for append and FileStatus for startFile()?{quote}
Updated the comment. Actually append may need to return FileStatus too along with LocatedBlock.
This requires more code refactoring when we start modifying append and other RPC calls to
include fileId. HDFS-4469 is to track this change.

  {quote}  FSNamesystem#getAdditionalBlock() does not seem to be using fileId?{quote}
It's due to the recent change in trunk. Rebased the patch.
   {quote} Please update the public APIs where new INodeIdMismatchedException can be thrown.
BTW INodeIdMismatchedException should be subclass of FileNotFoundException?{quote}
I removed INodeIdMismatchException, and used FileNotfoundException instead.
  {quote}  TestDFSClientRetries - unused import UnresolveLinkException. Cast to long unnecessary
for 1010 at two places. {quote}
Fixed.
   {quote} TestLeast - unused import anyCollection, FileStatus. Cast to long unnecessary for
1010 at two places. Why SuppressWarning? {quote}
Fixed.
   {quote} TestINodeFile - unused import DFSClient. Not sure why you need nnrpc and cannot
use fs? {quote}
nnrpc is used here to get the HdfsFileStatus. 

Thanks!

                
> Update addBlock() to inculde inode id as additional argument
> ------------------------------------------------------------
>
>                 Key: HDFS-4340
>                 URL: https://issues.apache.org/jira/browse/HDFS-4340
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: hdfs-client, namenode
>    Affects Versions: 3.0.0
>            Reporter: Brandon Li
>            Assignee: Brandon Li
>         Attachments: HDFS-4340.patch, HDFS-4340.patch, HDFS-4340.patch, HDFS-4340.patch,
HDFS-4340.patch, HDFS-4340.patch, HDFS-4340.patch, HDFS-4340.patch, HDFS-4340.patch, HDFS-4340.patch
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message