hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Konstantin Shvachko (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-4268) Remove redundant enum NNHAStatusHeartbeat.State
Date Fri, 15 Feb 2013 05:07:13 GMT

    [ https://issues.apache.org/jira/browse/HDFS-4268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13578947#comment-13578947

Konstantin Shvachko commented on HDFS-4268:

{{HAServiceState.INITIALIZING}} means that {{NameNode.state == null}}. Based on the initialization
sequence this means RPC server has not started and therefore there cannot be any heartbeats.
Do you have a use case for AssertError?
> Remove redundant enum NNHAStatusHeartbeat.State
> -----------------------------------------------
>                 Key: HDFS-4268
>                 URL: https://issues.apache.org/jira/browse/HDFS-4268
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: namenode
>    Affects Versions: 2.0.2-alpha
>            Reporter: Konstantin Shvachko
>            Assignee: Konstantin Shvachko
>             Fix For: 2.0.3-alpha
>         Attachments: heartbeatHAState.patch, heartbeatHAState.patch
> NNHAStatusHeartbeat.State is redundant and can be replaced with commonly used enum HAServiceState.
> We should also consistently use HAServiceState to check if the state is ACTIVE or STANDBY
rather than using {{instanceof}}.

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

View raw message