hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Eugene Koontz (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-3627) OfflineImageViewer oiv Indented processor prints out the Java class name in the DELEGATION_KEY field
Date Mon, 25 Feb 2013 19:14:12 GMT

    [ https://issues.apache.org/jira/browse/HDFS-3627?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13586159#comment-13586159
] 

Eugene Koontz commented on HDFS-3627:
-------------------------------------

Hi Scott,
The patch looks good to me, overall - just some nits about {{TestDelegationKey.java}}:

-java. imports should precede org.apache. imports.
-avoid use of "import <ns>.*" where possible.
(For correct {{import}} style, look at {{hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/security/token/delegation/TestDelegationToken.java}}
(in the same directory as your test).

-whitespace indentation beginning at {{String nullString = null;}} is inconsistent.
-why use {{nullString}} and {{nullByte}} rather than just {{null}}? Can't you instead do by
casting, i.e.
{{DelegationKey(keyId, expiryDate, (String)null);}}
-Make {{nullString}} and {{nullByte}} {{const}} (if you really need these null objects).

                
> OfflineImageViewer oiv Indented processor prints out the Java class name in the DELEGATION_KEY
field
> ----------------------------------------------------------------------------------------------------
>
>                 Key: HDFS-3627
>                 URL: https://issues.apache.org/jira/browse/HDFS-3627
>             Project: Hadoop HDFS
>          Issue Type: Bug
>    Affects Versions: 0.23.0
>            Reporter: Ravi Prakash
>            Priority: Minor
>         Attachments: HDFS-3627.patch, HDFS-3627.patch
>
>
> Instead of the contents of the delegation key this is printed out
> DELEGATION_KEY = org.apache.hadoop.security.token.delegation.DelegationKey@1e2ca7
>     DELEGATION_KEY = org.apache.hadoop.security.token.delegation.DelegationKey@105bd58
>     DELEGATION_KEY = org.apache.hadoop.security.token.delegation.DelegationKey@1d1e730
>     DELEGATION_KEY = org.apache.hadoop.security.token.delegation.DelegationKey@1a116c9
>     DELEGATION_KEY = org.apache.hadoop.security.token.delegation.DelegationKey@df1832

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message