Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Reply-To: hdfs-issues@hadoop.apache.org
Date: Wed, 16 Jan 2013 06:18:13 +0000 (UTC)
From: "Jing Zhao (JIRA)" <jira@apache.org>
To: hdfs-issues@hadoop.apache.org
Message-ID: <JIRA.12627767.1358306074390.143572.1358317093142@arcas>
In-Reply-To: <JIRA.12627767.1358306074390@arcas>
References: <JIRA.12627767.1358306074390@arcas>
Subject: [jira] [Commented] (HDFS-4407) In INodeDirectoryWithSnapshot,
 change combinePostDiff to merge-sort like
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HDFS-4407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13554782#comment-13554782 ] 

Jing Zhao commented on HDFS-4407:
---------------------------------

The patch looks good. It also passed all the snapshot-related tests on my machine. +1 for the patch. 
                
> In INodeDirectoryWithSnapshot, change combinePostDiff to merge-sort like
> ------------------------------------------------------------------------
>
>                 Key: HDFS-4407
>                 URL: https://issues.apache.org/jira/browse/HDFS-4407
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: namenode
>            Reporter: Tsz Wo (Nicholas), SZE
>            Assignee: Tsz Wo (Nicholas), SZE
>         Attachments: h4407_20130115.patch
>
>
> Change combinePostDiff to merge-sort like so that it is more efficient.  Also, it should not modify the postDiff parameter.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira