Return-Path: X-Original-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 7A8BDE2D0 for ; Mon, 7 Jan 2013 20:44:14 +0000 (UTC) Received: (qmail 76616 invoked by uid 500); 7 Jan 2013 20:44:14 -0000 Delivered-To: apmail-hadoop-hdfs-issues-archive@hadoop.apache.org Received: (qmail 76575 invoked by uid 500); 7 Jan 2013 20:44:14 -0000 Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: hdfs-issues@hadoop.apache.org Delivered-To: mailing list hdfs-issues@hadoop.apache.org Received: (qmail 76565 invoked by uid 99); 7 Jan 2013 20:44:14 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 07 Jan 2013 20:44:14 +0000 Date: Mon, 7 Jan 2013 20:44:14 +0000 (UTC) From: "Todd Lipcon (JIRA)" To: hdfs-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HDFS-4353) Encapsulate connections to peers in Peer and PeerServer classes MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HDFS-4353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13546246#comment-13546246 ] Todd Lipcon commented on HDFS-4353: ----------------------------------- Latest patch looks good. +1 pending Jenkins. > Encapsulate connections to peers in Peer and PeerServer classes > --------------------------------------------------------------- > > Key: HDFS-4353 > URL: https://issues.apache.org/jira/browse/HDFS-4353 > Project: Hadoop HDFS > Issue Type: Sub-task > Components: datanode, hdfs-client > Affects Versions: 2.0.3-alpha > Reporter: Colin Patrick McCabe > Assignee: Colin Patrick McCabe > Attachments: 02b-cumulative.patch, 02c.patch, 02c.patch, 02-cumulative.patch, 02d.patch, 02e.patch, 02f.patch > > > Encapsulate connections to peers into the {{Peer}} and {{PeerServer}} classes. Since many Java classes may be involved with these connections, it makes sense to create a container for them. For example, a connection to a peer may have an input stream, output stream, readablebytechannel, encrypted output stream, and encrypted input stream associated with it. > This makes us less dependent on the {{NetUtils}} methods which use {{instanceof}} to manipulate socket and stream states based on the runtime type. it also paves the way to introduce UNIX domain sockets which don't inherit from {{java.net.Socket}}. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira