Return-Path: X-Original-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id C22A1E8B0 for ; Tue, 8 Jan 2013 09:32:14 +0000 (UTC) Received: (qmail 8621 invoked by uid 500); 8 Jan 2013 09:32:14 -0000 Delivered-To: apmail-hadoop-hdfs-issues-archive@hadoop.apache.org Received: (qmail 8362 invoked by uid 500); 8 Jan 2013 09:32:14 -0000 Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: hdfs-issues@hadoop.apache.org Delivered-To: mailing list hdfs-issues@hadoop.apache.org Received: (qmail 8312 invoked by uid 99); 8 Jan 2013 09:32:13 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 08 Jan 2013 09:32:13 +0000 Date: Tue, 8 Jan 2013 09:32:13 +0000 (UTC) From: "Tsz Wo (Nicholas), SZE (JIRA)" To: hdfs-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HDFS-4340) Update addBlock() to inculde inode id as additional argument MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HDFS-4340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13546729#comment-13546729 ] Tsz Wo (Nicholas), SZE commented on HDFS-4340: ---------------------------------------------- - The DFSOutputStream constructor for append does not set fileId. It would be great if we can change fileId to final. However, it may need some refactoring of the constructors. - The DFSOutputStream constructor for create should not have an additional RPC call to namenode.getFileInfo(src). Change create(..) to return fileId (or HdfsFileStatus.) - With fileId, the source path is no longer needed for ClientProtocol.addBlock(..). Howw about using the src String parameter to pass fileId? The server side can determine whether it is a path or file id by the leading "/". This may be a wild suggestion. Please see if you think it is a good idea. - Need to change WebHDFS to support file ID. This may be done in a separated JIRA. - Before changing WebHDFS, add file_id to the other HdfsFileStatus constructor and then pass GRANDFATHER_INODE_ID in the caller. - Similarly, add file_id to HdfsLocatedFileStatus constructor. Then you don't have to add a new constructor. - It should not pass GRANDFATHER_INODE_ID in checkLease(..). The file id should be availabe for all cases. We need to add fileId to other RPC methods such as abandonBlock(..), complete(..), etc. Are you plan to do it separately? - Why change SequentialNumber to public? > Update addBlock() to inculde inode id as additional argument > ------------------------------------------------------------ > > Key: HDFS-4340 > URL: https://issues.apache.org/jira/browse/HDFS-4340 > Project: Hadoop HDFS > Issue Type: Sub-task > Components: hdfs-client, namenode > Affects Versions: 3.0.0 > Reporter: Brandon Li > Assignee: Brandon Li > Attachments: HDFS-4340.patch > > -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira