Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Reply-To: hdfs-issues@hadoop.apache.org
Date: Tue, 8 Jan 2013 21:50:14 +0000 (UTC)
From: "Eli Collins (JIRA)" <jira@apache.org>
To: hdfs-issues@hadoop.apache.org
Message-ID: <JIRA.12611265.1349910739751.99699.1357681814493@arcas>
In-Reply-To: <JIRA.12611265.1349910739751@arcas>
References: <JIRA.12611265.1349910739751@arcas>
Subject: [jira] [Updated] (HDFS-4031) Update findbugsExcludeFile.xml to
 include findbugs 2 exclusions
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


     [ https://issues.apache.org/jira/browse/HDFS-4031?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Eli Collins updated HDFS-4031:
------------------------------

          Resolution: Fixed
       Fix Version/s: 2.0.3-alpha
    Target Version/s:   (was: 2.0.3-alpha)
        Hadoop Flags: Reviewed
              Status: Resolved  (was: Patch Available)

I've merged this to branch-2.
                
> Update findbugsExcludeFile.xml to include findbugs 2 exclusions
> ---------------------------------------------------------------
>
>                 Key: HDFS-4031
>                 URL: https://issues.apache.org/jira/browse/HDFS-4031
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: namenode
>    Affects Versions: 2.0.0-alpha
>            Reporter: Eli Collins
>            Assignee: Eli Collins
>             Fix For: 2.0.3-alpha
>
>         Attachments: hdfs-4031.txt
>
>
> Findbugs 2 warns about some volatile increments (VO_VOLATILE_INCREMENT) that unlike HDFS-4029 and HDFS-4030 are less problematic:
> - numFailedVolumes is only incremented in one thread and that access is synchronized
> - pendingReceivedRequests in BPServiceActor is clearly synchronized
> It would be reasonable to make these Atomics as well but I think they're uses are clearly correct so figured for these the warning was more obviously bogus and so could be ignored.
> There's also a SE_BAD_FIELD_INNER_CLASS warning (LocalDatanodeInfo's anonymous class is serializable but it is not) in BPServiceActor is OK to ignore since we don't serialize LocalDatanodeInfo.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira