hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-4451) hdfs balancer command returns exit code 1 on success instead of 0
Date Thu, 31 Jan 2013 19:35:15 GMT

    [ https://issues.apache.org/jira/browse/HDFS-4451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13568012#comment-13568012
] 

Hadoop QA commented on HDFS-4451:
---------------------------------

{color:green}+1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12567400/HDFS-4451.patch
  against trunk revision .

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:green}+1 tests included{color}.  The patch appears to include 1 new or modified
test files.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of
javac compiler warnings.

    {color:green}+1 javadoc{color}.  The javadoc tool did not generate any warning messages.

    {color:green}+1 eclipse:eclipse{color}.  The patch built with eclipse:eclipse.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new Findbugs (version
1.3.9) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number
of release audit warnings.

    {color:green}+1 core tests{color}.  The patch passed unit tests in hadoop-hdfs-project/hadoop-hdfs.

    {color:green}+1 contrib tests{color}.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/3917//testReport/
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/3917//console

This message is automatically generated.
                
> hdfs balancer command returns exit code 1 on success instead of 0
> -----------------------------------------------------------------
>
>                 Key: HDFS-4451
>                 URL: https://issues.apache.org/jira/browse/HDFS-4451
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: balancer
>    Affects Versions: 2.0.2-alpha
>         Environment: Centos 6.3, JDK 1.6.0_25
>            Reporter: Joshua Blatt
>             Fix For: 2.0.3-alpha
>
>         Attachments: HDFS-4451.patch, HDFS-4451.patch, HDFS-4451.patch
>
>
> Though the org.apache.hadoop.util.Tool interface javadocs indicate  implementations should
return 0 on success, the org.apache.hadoop.hdfs.server.balance.Balancer.Cli implementation
returns the int values of this enum instead:
>   // Exit status
>   enum ReturnStatus {
>     SUCCESS(1),
>     IN_PROGRESS(0),
>     ALREADY_RUNNING(-1),
>     NO_MOVE_BLOCK(-2),
>     NO_MOVE_PROGRESS(-3),
>     IO_EXCEPTION(-4),
>     ILLEGAL_ARGS(-5),
>     INTERRUPTED(-6);
> This created an issue for us when we tried to run the hdfs balancer as a cron job.  
Cron sends emails whenever a executable it runs exits non-zero.   We'd either have to disable
all emails and miss real issues or fix this bug.
> I think both SUCCESS and IN_PROGRESS ReturnStatuses should lead to exit 0.
> Marking this change as incompatible because existing scripts which interpret exit 1 as
success will be broken (unless they defensively/liberally interpret both exit 1 and exit 0
as success).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message