hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Todd Lipcon (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-4433) make TestPeerCache not flaky
Date Wed, 23 Jan 2013 20:01:16 GMT

    [ https://issues.apache.org/jira/browse/HDFS-4433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13561034#comment-13561034
] 

Todd Lipcon commented on HDFS-4433:
-----------------------------------

Good catches. +1
                
> make TestPeerCache not flaky
> ----------------------------
>
>                 Key: HDFS-4433
>                 URL: https://issues.apache.org/jira/browse/HDFS-4433
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: datanode, hdfs-client, performance
>            Reporter: Colin Patrick McCabe
>            Assignee: Colin Patrick McCabe
>            Priority: Minor
>         Attachments: HDFS-4433.001.patch
>
>
> TestPeerCache is flaky now because it relies on using the same global cache for every
test function.  So the cache timeout can't be set to something different for each test.
> Also, we should implement equals and hashCode for {{FakePeer}}, since otherwise {{testMultiplePeersWithSameDnId}}
is not really testing what happens when multiple equal peers are inserted into the cache.
 (The default equals is object equality).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message