hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Todd Lipcon (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-4402) some small DomainSocket fixes: avoid findbugs warning, change log level, etc.
Date Tue, 15 Jan 2013 00:20:13 GMT

    [ https://issues.apache.org/jira/browse/HDFS-4402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13553322#comment-13553322
] 

Todd Lipcon commented on HDFS-4402:
-----------------------------------

The new LENGTH constant isn't necessary - you can use BlockMetadataHeader.getHeaderSize()
instead.

Otherwise looks good.
                
> some small DomainSocket fixes: avoid findbugs warning, change log level, etc.
> -----------------------------------------------------------------------------
>
>                 Key: HDFS-4402
>                 URL: https://issues.apache.org/jira/browse/HDFS-4402
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>            Reporter: Colin Patrick McCabe
>            Priority: Minor
>         Attachments: HDFS-4402.001.patch
>
>
> Some miscellaneous fixes:
> * findbugs complains about a short-circuit operator in {{DomainSocket.java}} for some
reason.  We don't need it (it doesn't help optimization since the expressions lack side-effects),
so let's ditch it to avoid the findbugs warning.
> * change the log level of one error message to warn
> * BlockReaderLocal should use a BufferedInputStream to read the metadata file header,
to avoid doing multiple small reads.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message