hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Suresh Srinivas (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-4393) Empty request and responses in protocol translators can be static final members
Date Thu, 17 Jan 2013 18:16:14 GMT

    [ https://issues.apache.org/jira/browse/HDFS-4393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13556431#comment-13556431
] 

Suresh Srinivas commented on HDFS-4393:
---------------------------------------

+1 for the patch
                
> Empty request and responses in protocol translators can be static final members
> -------------------------------------------------------------------------------
>
>                 Key: HDFS-4393
>                 URL: https://issues.apache.org/jira/browse/HDFS-4393
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>    Affects Versions: 3.0.0
>            Reporter: Brandon Li
>            Assignee: Brandon Li
>            Priority: Minor
>         Attachments: HDFS-4393.patch, HDFS-4393.patch, HDFS-4393.patch
>
>
> Some of the empty request and responses in protocol translators are unnecessarily created
every time. They can be static final members in the translators. 
> Example: ClientNamenodeProtocolTranslatorPB.java
>     GetServerDefaultsRequestProto req = GetServerDefaultsRequestProto.newBuilder().build();

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message