hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Eli Collins (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (HDFS-4377) Some trivial DN comment cleanup
Date Wed, 09 Jan 2013 20:10:13 GMT

     [ https://issues.apache.org/jira/browse/HDFS-4377?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel

Eli Collins updated HDFS-4377:

    Attachment: hdfs-4377.txt

Thanks for the review Todd. Updated patch attached.

#1 Good catch, I just noticed the type changed recently and updated the comment naively. I
re-wrote it now. Related, I filed HDFS-4378 to make StorageID a class so the types are more
readable and the code is less error prone.

#2 I rewrote the implementation comment to fix spelling mistakes/grammar and hopefully improve
the explanation.
> Some trivial DN comment cleanup
> -------------------------------
>                 Key: HDFS-4377
>                 URL: https://issues.apache.org/jira/browse/HDFS-4377
>             Project: Hadoop HDFS
>          Issue Type: Bug
>    Affects Versions: 2.0.0-alpha
>            Reporter: Eli Collins
>            Assignee: Eli Collins
>            Priority: Minor
>         Attachments: hdfs-4377.txt, hdfs-4377.txt
> DataStorage.java
> - The "initilized" member is misspelled
> - Comment what the storageID member is
> DataNode.java
> - Cleanup createNewStorageId comment (should mention the port is included and is overly
> BlockManager.java
> - TreeSet in the comment should be TreeMap

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

View raw message