hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Todd Lipcon (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-4356) BlockReaderLocal should use passed file descriptors rather than paths
Date Fri, 11 Jan 2013 00:52:13 GMT

    [ https://issues.apache.org/jira/browse/HDFS-4356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13550640#comment-13550640

Todd Lipcon commented on HDFS-4356:

+    if (fisCache != null) {
+      LOG.debug("putting FileInputStream for " + filename +
+          " back into FileInputStreamCache");
+      fisCache.put(datanodeID, block, new FileInputStream[] {dataIn, checksumIn});

I think this is actually the code I meant to point to when I asked to add a guard. Copy-paste
fail. *This* is on the hot path for reads. (also the debug just below this one)

+      = new ScheduledThreadPoolExecutor(1, new Daemon.DaemonFactory());
This only addressed half of the above comment. The thread needs a name. Check out ThreadFactoryBuilder
from guava.

+  /**
+   * True if the FileInputStream is closed.
+   */
Bad doc -- should be: "True if the FileInputStreamCache has been closed"

> BlockReaderLocal should use passed file descriptors rather than paths
> ---------------------------------------------------------------------
>                 Key: HDFS-4356
>                 URL: https://issues.apache.org/jira/browse/HDFS-4356
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: datanode, hdfs-client, performance
>    Affects Versions: 2.0.3-alpha
>            Reporter: Colin Patrick McCabe
>            Assignee: Colin Patrick McCabe
>         Attachments: 04b-cumulative.patch, _04b.patch, _04c.patch, 04-cumulative.patch,
04d-cumulative.patch, _04e.patch, 04f-cumulative.patch, 04g-cumulative.patch
> {{BlockReaderLocal}} should use file descriptors passed over UNIX domain sockets rather
than paths.  We also need some configuration options for these UNIX domain sockets.

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

View raw message