hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-4351) Fix BlockPlacementPolicyDefault#chooseTarget when avoiding stale nodes
Date Mon, 07 Jan 2013 13:26:14 GMT

    [ https://issues.apache.org/jira/browse/HDFS-4351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13545867#comment-13545867
] 

Hudson commented on HDFS-4351:
------------------------------

Integrated in Hadoop-Hdfs-trunk #1278 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk/1278/])
    HDFS-4351.  In BlockPlacementPolicyDefault.chooseTarget(..), numOfReplicas needs to be
updated when avoiding stale nodes.  Contributed by Andrew Wang (Revision 1429653)

     Result = FAILURE
szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1429653
Files : 
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/BlockPlacementPolicyDefault.java
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/blockmanagement/TestReplicationPolicy.java

                
> Fix BlockPlacementPolicyDefault#chooseTarget when avoiding stale nodes
> ----------------------------------------------------------------------
>
>                 Key: HDFS-4351
>                 URL: https://issues.apache.org/jira/browse/HDFS-4351
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: namenode
>    Affects Versions: 1.2.0, 3.0.0
>            Reporter: Andrew Wang
>            Assignee: Andrew Wang
>             Fix For: 1.2.0, 2.0.3-alpha
>
>         Attachments: hdfs-4351-2.patch, hdfs-4351-3.patch, hdfs-4351-4.patch, hdfs-4351-branch-1-1.patch,
hdfs-4351.patch
>
>
> There's a bug in {{BlockPlacementPolicyDefault#chooseTarget}} with stale node avoidance
enabled (HDFS-3912). If a NotEnoughReplicasException is thrown in the call to {{chooseRandom()}},
{{numOfReplicas}} is not updated together with the partial result in {{result}} since it is
pass by value. The retry call to {{chooseTarget}} then uses this incorrect value.
> This can be seen if you enable stale node detection for {{TestReplicationPolicy#testChooseTargetWithMoreThanAvaiableNodes()}}.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message