hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-4350) Make enabling of stale marking on read and write paths independent
Date Wed, 16 Jan 2013 03:16:13 GMT

    [ https://issues.apache.org/jira/browse/HDFS-4350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13554699#comment-13554699
] 

Hadoop QA commented on HDFS-4350:
---------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12565057/hdfs-4350.txt
  against trunk revision .

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:green}+1 tests included{color}.  The patch appears to include 3 new or modified
test files.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of
javac compiler warnings.

    {color:green}+1 javadoc{color}.  The javadoc tool did not generate any warning messages.

    {color:green}+1 eclipse:eclipse{color}.  The patch built with eclipse:eclipse.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new Findbugs (version
1.3.9) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number
of release audit warnings.

    {color:red}-1 core tests{color}.  The patch failed these unit tests in hadoop-hdfs-project/hadoop-hdfs:

                  org.apache.hadoop.hdfs.server.blockmanagement.TestBlockManager

    {color:green}+1 contrib tests{color}.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/3845//testReport/
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/3845//console

This message is automatically generated.
                
> Make enabling of stale marking on read and write paths independent
> ------------------------------------------------------------------
>
>                 Key: HDFS-4350
>                 URL: https://issues.apache.org/jira/browse/HDFS-4350
>             Project: Hadoop HDFS
>          Issue Type: Bug
>    Affects Versions: 3.0.0
>            Reporter: Andrew Wang
>            Assignee: Andrew Wang
>         Attachments: hdfs-4350-1.patch, hdfs-4350-2.patch, hdfs-4350-3.patch, hdfs-4350-4.patch,
hdfs-4350.txt
>
>
> Marking of datanodes as stale for the read and write path was introduced in HDFS-3703
and HDFS-3912 respectively. This is enabled using two new keys, {{DFS_NAMENODE_CHECK_STALE_DATANODE_KEY}}
and {{DFS_NAMENODE_AVOID_STALE_DATANODE_FOR_WRITE_KEY}}. However, there currently exists a
dependency, since you cannot enable write marking without also enabling read marking, since
the first key enables both checking of staleness and read marking.
> I propose renaming the first key to {{DFS_NAMENODE_AVOID_STALE_DATANODE_FOR_READ_KEY}},
and make checking enabled if either of the keys are set. This will allow read and write marking
to be enabled independently.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message