hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tsz Wo (Nicholas), SZE (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-4340) Update addBlock() to inculde inode id as additional argument
Date Tue, 08 Jan 2013 09:32:13 GMT

    [ https://issues.apache.org/jira/browse/HDFS-4340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13546729#comment-13546729
] 

Tsz Wo (Nicholas), SZE commented on HDFS-4340:
----------------------------------------------

- The DFSOutputStream constructor for append does not set fileId.  It would be great if we
can change fileId to final.  However, it may need some refactoring of the constructors.

- The DFSOutputStream constructor for create should not have an additional RPC call to namenode.getFileInfo(src).
 Change create(..) to return fileId (or HdfsFileStatus.)

- With fileId, the source path is no longer needed for ClientProtocol.addBlock(..).  Howw
about using the src String parameter to pass fileId?  The server side can determine whether
it is a path or file id by the leading "/".  This may be a wild suggestion.  Please see if
you think it is a good idea.

- Need to change WebHDFS to support file ID.  This may be done in a separated JIRA.

- Before changing WebHDFS, add file_id to the other HdfsFileStatus constructor and then pass
GRANDFATHER_INODE_ID in the caller.

- Similarly, add file_id to HdfsLocatedFileStatus constructor.  Then you don't have to add
a new constructor.

- It should not pass GRANDFATHER_INODE_ID in checkLease(..).  The file id should be availabe
for all cases.  We need to add fileId to other RPC methods such as abandonBlock(..), complete(..),
etc.  Are you plan to do it separately?

- Why change SequentialNumber to public?


                
> Update addBlock() to inculde inode id as additional argument
> ------------------------------------------------------------
>
>                 Key: HDFS-4340
>                 URL: https://issues.apache.org/jira/browse/HDFS-4340
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: hdfs-client, namenode
>    Affects Versions: 3.0.0
>            Reporter: Brandon Li
>            Assignee: Brandon Li
>         Attachments: HDFS-4340.patch
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message