hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Andy Isaacson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-4237) Add unit tests for HTTP-based filesystems against secure MiniDFSCluster
Date Fri, 11 Jan 2013 02:50:13 GMT

    [ https://issues.apache.org/jira/browse/HDFS-4237?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13550736#comment-13550736
] 

Andy Isaacson commented on HDFS-4237:
-------------------------------------

A few tab characters crept into your patch.  Please take them out.

{code}
+// We ignore this test class because the test cases should be run only
+// when external Kdc parameters are specified. TestSecureWebHDFS
+// checks if these settings are set using JUnit4 Assume, which does
+// not work with TestCase (JUnit 3.x). Read GRADLE-1879 for more
+// information.
{code}
Given that this is going into hadoop-hdfs, I don't see why we need to support jUnit 3.

{code}
+    TestWebHDFS.largeFileTest(conf, 200L << 20, secureUgi); //200MB file length
{code}
I'd rather see it written as 200 * 1024 * 1024 rather than using a bitshift.

Other than those issues, it seems reasonable.  Presumably this requires special permissions
to run as root to get ports<1023, can we document that process somewhere?
                
> Add unit tests for HTTP-based filesystems against secure MiniDFSCluster
> -----------------------------------------------------------------------
>
>                 Key: HDFS-4237
>                 URL: https://issues.apache.org/jira/browse/HDFS-4237
>             Project: Hadoop HDFS
>          Issue Type: Test
>          Components: security, test, webhdfs
>    Affects Versions: 2.0.0-alpha
>            Reporter: Stephen Chu
>            Assignee: Stephen Chu
>         Attachments: HDFS-4237.patch.001
>
>
> Now that we can start a secure MiniDFSCluster (HADOOP-9004), we need more security unit
tests.
> A good area to add secure tests is the HTTP-based filesystems (WebHDFS, HttpFs).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message