hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-4035) LightWeightGSet and LightWeightHashSet increment a volatile without synchronization
Date Wed, 09 Jan 2013 10:48:18 GMT

    [ https://issues.apache.org/jira/browse/HDFS-4035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13548371#comment-13548371
] 

Hudson commented on HDFS-4035:
------------------------------

Integrated in Hadoop-Yarn-trunk #91 (See [https://builds.apache.org/job/Hadoop-Yarn-trunk/91/])
    HDFS-4035. LightWeightGSet and LightWeightHashSet increment a volatile without synchronization.
Contributed by Eli Collins (Revision 1430595)

     Result = SUCCESS
eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1430595
Files : 
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/dev-support/findbugsExcludeFile.xml

                
> LightWeightGSet and LightWeightHashSet increment a volatile without synchronization
> -----------------------------------------------------------------------------------
>
>                 Key: HDFS-4035
>                 URL: https://issues.apache.org/jira/browse/HDFS-4035
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>    Affects Versions: 2.0.0-alpha
>            Reporter: Eli Collins
>            Assignee: Eli Collins
>             Fix For: 2.0.3-alpha
>
>         Attachments: hdfs-4035.txt
>
>
> LightWeightGSet and LightWeightHashSet have a volatile modification field that they use
to detect updates while iterating so they can throw a ConcurrentModificationException. Since
these "LightWeight" classes are explicitly "not thread safe" (eg access to their members is
not synchronized) then the current use is OK, we just need to update findbugsExcludeFile.xml
to exclude them.
>   

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message