hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-4031) Update findbugsExcludeFile.xml to include findbugs 2 exclusions
Date Wed, 09 Jan 2013 10:48:32 GMT

    [ https://issues.apache.org/jira/browse/HDFS-4031?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13548381#comment-13548381
] 

Hudson commented on HDFS-4031:
------------------------------

Integrated in Hadoop-Yarn-trunk #91 (See [https://builds.apache.org/job/Hadoop-Yarn-trunk/91/])
    HDFS-4031. Update findbugsExcludeFile.xml to include findbugs 2 exclusions. Contributed
by Eli Collins (Revision 1430468)

     Result = SUCCESS
eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1430468
Files : 
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/dev-support/findbugsExcludeFile.xml

                
> Update findbugsExcludeFile.xml to include findbugs 2 exclusions
> ---------------------------------------------------------------
>
>                 Key: HDFS-4031
>                 URL: https://issues.apache.org/jira/browse/HDFS-4031
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: namenode
>    Affects Versions: 2.0.0-alpha
>            Reporter: Eli Collins
>            Assignee: Eli Collins
>             Fix For: 2.0.3-alpha
>
>         Attachments: hdfs-4031.txt
>
>
> Findbugs 2 warns about some volatile increments (VO_VOLATILE_INCREMENT) that unlike HDFS-4029
and HDFS-4030 are less problematic:
> - numFailedVolumes is only incremented in one thread and that access is synchronized
> - pendingReceivedRequests in BPServiceActor is clearly synchronized
> It would be reasonable to make these Atomics as well but I think they're uses are clearly
correct so figured for these the warning was more obviously bogus and so could be ignored.
> There's also a SE_BAD_FIELD_INNER_CLASS warning (LocalDatanodeInfo's anonymous class
is serializable but it is not) in BPServiceActor is OK to ignore since we don't serialize
LocalDatanodeInfo.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message