hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-3970) BlockPoolSliceStorage#doRollback(..) should use BlockPoolSliceStorage instead of DataStorage to read prev version file.
Date Tue, 08 Jan 2013 13:14:13 GMT

    [ https://issues.apache.org/jira/browse/HDFS-3970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13546864#comment-13546864
] 

Hudson commented on HDFS-3970:
------------------------------

Integrated in Hadoop-Hdfs-trunk #1279 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk/1279/])
    HDFS-3970. Fix bug causing rollback of HDFS upgrade to result in bad VERSION file. Contributed
by Vinay and Andrew Wang. (Revision 1430037)

     Result = FAILURE
atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1430037
Files : 
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/BlockPoolSliceStorage.java
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDFSRollback.java

                
> BlockPoolSliceStorage#doRollback(..) should use BlockPoolSliceStorage instead of DataStorage
to read prev version file.
> -----------------------------------------------------------------------------------------------------------------------
>
>                 Key: HDFS-3970
>                 URL: https://issues.apache.org/jira/browse/HDFS-3970
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: datanode
>    Affects Versions: 3.0.0, 2.0.2-alpha
>            Reporter: Vinay
>            Assignee: Andrew Wang
>             Fix For: 2.0.3-alpha
>
>         Attachments: hdfs-3970-1.patch, HDFS-3970.patch
>
>
> {code}    // read attributes out of the VERSION file of previous directory
>     DataStorage prevInfo = new DataStorage();
>     prevInfo.readPreviousVersionProperties(bpSd);{code}
> In the above code snippet BlockPoolSliceStorage instance should be used. other wise rollback
results in 'storageType' property missing which will not be there in initial VERSION file.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message