Return-Path: X-Original-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 5BCC0D48B for ; Wed, 12 Dec 2012 07:31:24 +0000 (UTC) Received: (qmail 74036 invoked by uid 500); 12 Dec 2012 07:31:23 -0000 Delivered-To: apmail-hadoop-hdfs-issues-archive@hadoop.apache.org Received: (qmail 73566 invoked by uid 500); 12 Dec 2012 07:31:22 -0000 Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: hdfs-issues@hadoop.apache.org Delivered-To: mailing list hdfs-issues@hadoop.apache.org Received: (qmail 73536 invoked by uid 99); 12 Dec 2012 07:31:22 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 12 Dec 2012 07:31:22 +0000 Date: Wed, 12 Dec 2012 07:31:22 +0000 (UTC) From: "Binglin Chang (JIRA)" To: hdfs-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Updated] (HDFS-4306) PBHelper.convertLocatedBlock miss convert BlockToken MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HDFS-4306?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Binglin Chang updated HDFS-4306: -------------------------------- Attachment: HDFS-4306.patch Changes: Reuse PBHelper.convert instead of writing repeated convert code. In testConvertLocatedBlock, set blockToken to non default value, so "compare(lb.getBlockToken(), lb2.getBlockToken())" actually mean something. Add testConvertLocatedBlockArray and testConvertLocatedBlockList > PBHelper.convertLocatedBlock miss convert BlockToken > ---------------------------------------------------- > > Key: HDFS-4306 > URL: https://issues.apache.org/jira/browse/HDFS-4306 > Project: Hadoop HDFS > Issue Type: Bug > Reporter: Binglin Chang > Assignee: Binglin Chang > Attachments: HDFS-4306.patch > > > PBHelper.convertLocatedBlock(from protobuf array to primitive array) miss convert BlockToken. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira