hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Konstantin Boudnik (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-4349) Test reading files from BackupNode
Date Mon, 31 Dec 2012 20:16:12 GMT

    [ https://issues.apache.org/jira/browse/HDFS-4349?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13541488#comment-13541488
] 

Konstantin Boudnik commented on HDFS-4349:
------------------------------------------

The patch looks good. Two cosmetic comments:
- {{+          DFSConfigKeys.DFS_NAMENODE_RPC_ADDRESS_KEY + ".bnCluter";}} - I believe it
is {{bnCluster}} ?
- there is a whilespace change only here
{noformat}
     assert out.getLength() == 0 : "Output buffer is not empty";
-    
+
+    if (doubleBuf.isFlushed()) {
{noformat}

+1 otherwise
                
> Test reading files from BackupNode
> ----------------------------------
>
>                 Key: HDFS-4349
>                 URL: https://issues.apache.org/jira/browse/HDFS-4349
>             Project: Hadoop HDFS
>          Issue Type: Test
>          Components: namenode, test
>    Affects Versions: 2.0.2-alpha
>            Reporter: Konstantin Shvachko
>            Assignee: Konstantin Shvachko
>         Attachments: BNCanRead.patch
>
>
> Add a test that ensures files are readable both from NameNode and BackupNode.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message