hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Junping Du (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-4337) Backport HDFS-4240 to branch-1: Make sure nodes are avoided to place replica if some replica are already under the same nodegroup.
Date Thu, 27 Dec 2012 06:48:12 GMT

    [ https://issues.apache.org/jira/browse/HDFS-4337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13539848#comment-13539848
] 

Junping Du commented on HDFS-4337:
----------------------------------

Thanks for updating in v2 patch. The patch looks good to me but a minor issue below:
The method of checkTargetsOnDifferentNodeGroup() in TestReplicationPolicyWithNodeGroup(),
you should use indent 2 instead of 3:
{noformat}
    if(targets.length == 0)
       return true;
{noformat}
Can you correct it and post the test-patch result on branch-1? Thanks!
BTW, you don't have to remove previous patch in updating a new one. Also, for non-trunk patch,
please get rid of submit patch. As current pre-commit test only for trunk branch.
                
> Backport HDFS-4240 to branch-1: Make sure nodes are avoided to place replica if some
replica are already under the same nodegroup.
> ----------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: HDFS-4337
>                 URL: https://issues.apache.org/jira/browse/HDFS-4337
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: namenode
>    Affects Versions: 1.2.0
>            Reporter: Junping Du
>            Assignee: meng gong
>              Labels: patch
>         Attachments: HDFS-4337-v2.patch
>
>
> Update affects version from 1.0.0 to 1.2.0.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message