hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Junping Du (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-4337) Backport HDFS-4240 to branch-1: Make sure nodes are avoided to place replica if some replica are already under the same nodegroup.
Date Thu, 27 Dec 2012 04:04:12 GMT

    [ https://issues.apache.org/jira/browse/HDFS-4337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13539821#comment-13539821
] 

Junping Du commented on HDFS-4337:
----------------------------------

Thanks for the patch. There are some trivial issue need to be addressed here:
1. Fix an indent issue in method of addToExcludedNodes() in BlockPlacementPolicyWithNodeGroup.java
2. Fix indent issue in define dataNodesInBoundaryCase[] and dataNodesInMoreTargetsCase[] in
TestReplicationPolicyWithNodeGroup.java to keep consistent.
3. Replace unnecessary two blank lines below with one blank line
{noformat}
+     
+      File baseDir = new File(System.getProperty(
+           "test.build.data", "build/test/data"), "dfs/");
+      CONF.set(DFSConfigKeys.DFS_NAMENODE_NAME_DIR_KEY,
+           new File(baseDir, "name").getPath());
+            
+ 
{noformat}
4. Indent and unnecessary double blank lines issue for checkTargetsOnDifferentNodeGroup()
in TestReplicationPolicyWithNodeGroup.java
5. Indent issue for following code: 
{noformat}
+    for(int i=0; i<NUM_OF_DATANODES_BOUNDARY; i++) {
+        dataNodes[0].updateHeartbeat(
+                2*MIN_BLOCKS_FOR_WRITE*BLOCK_SIZE, 0L,
+                (MIN_BLOCKS_FOR_WRITE-1)*BLOCK_SIZE, 0);
+        
+      dataNodesInBoundaryCase[i].updateHeartbeat(
+          2*MIN_BLOCKS_FOR_WRITE*BLOCK_SIZE, 0L,
+          2*MIN_BLOCKS_FOR_WRITE*BLOCK_SIZE, 0);
+    }

{noformat}
6. Remove unnecessary blank lines in the last several lines of TestReplicationPolicyWithNodeGroup.java
                
> Backport HDFS-4240 to branch-1: Make sure nodes are avoided to place replica if some
replica are already under the same nodegroup.
> ----------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: HDFS-4337
>                 URL: https://issues.apache.org/jira/browse/HDFS-4337
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: namenode
>    Affects Versions: 1.2.0
>            Reporter: Junping Du
>            Assignee: meng gong
>              Labels: patch
>         Attachments: HDFS-4337-v1.patch
>
>
> Update affects version from 1.0.0 to 1.2.0.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message