hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Colin Patrick McCabe (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-4330) Support snapshots up to the snapshot limit
Date Thu, 27 Dec 2012 20:54:13 GMT

    [ https://issues.apache.org/jira/browse/HDFS-4330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13540147#comment-13540147
] 

Colin Patrick McCabe commented on HDFS-4330:
--------------------------------------------

Good to see that you addressed the issue with recursive calls.

{code}
+    try {
+      hdfs.createSnapshot("s" + s, dirStr);
+      Assert.fail();
+    } catch(IOException ioe) {
+      SnapshotTestHelper.LOG.info("Good!", ioe);
+    }
{code}

It seems like we could log something more descriptive than "Good!" on success.  Also, it might
be nice to have a descriptive message on failure-- something like "expected to fail to create
snapshot, but didn't".
                
> Support snapshots up to the snapshot limit
> ------------------------------------------
>
>                 Key: HDFS-4330
>                 URL: https://issues.apache.org/jira/browse/HDFS-4330
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: namenode
>            Reporter: Tsz Wo (Nicholas), SZE
>            Assignee: Tsz Wo (Nicholas), SZE
>         Attachments: h4330_20121227.patch
>
>
> Make sure that the SNAPSHOT_LIMIT (= 65536) per snapshottable directory can be supported.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message