hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Todd Lipcon (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-4306) PBHelper.convertLocatedBlock miss convert BlockToken
Date Wed, 12 Dec 2012 22:15:21 GMT

    [ https://issues.apache.org/jira/browse/HDFS-4306?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13530416#comment-13530416
] 

Todd Lipcon commented on HDFS-4306:
-----------------------------------

Hi Binglin. Good catch. Looking at this code, though, I'm not sure why we don't just do:
{code}
  public static LocatedBlock[] convertLocatedBlock(LocatedBlockProto[] lb) {
    if (lb == null) return null;
    return convertLocatedBlock(Arrays.asList(lb));
  }
{code}

Wouldn't that reduce duplicated code?
                
> PBHelper.convertLocatedBlock miss convert BlockToken
> ----------------------------------------------------
>
>                 Key: HDFS-4306
>                 URL: https://issues.apache.org/jira/browse/HDFS-4306
>             Project: Hadoop HDFS
>          Issue Type: Bug
>            Reporter: Binglin Chang
>            Assignee: Binglin Chang
>         Attachments: HDFS-4306.patch
>
>
> PBHelper.convertLocatedBlock(from protobuf array to primitive array) miss convert BlockToken.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message