hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Suresh Srinivas (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-4280) InodeTree.java has redundant check for vName while throwing exception
Date Thu, 06 Dec 2012 00:06:59 GMT

    [ https://issues.apache.org/jira/browse/HDFS-4280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13510952#comment-13510952
] 

Suresh Srinivas commented on HDFS-4280:
---------------------------------------

+1 for the change. Since you are in that part of the code, can you also do the following:
- resolveInternal should not throw FileNotFoundException
                
> InodeTree.java has redundant check for vName while throwing exception
> ---------------------------------------------------------------------
>
>                 Key: HDFS-4280
>                 URL: https://issues.apache.org/jira/browse/HDFS-4280
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>            Reporter: Arup Malakar
>            Priority: Trivial
>         Attachments: HDFS-4280_trunk.patch
>
>
> {code}
> 337	    if (!gotMountTableEntry) {
> 338	      throw new IOException(
> 339	          "ViewFs: Cannot initialize: Empty Mount table in config for " + 
> 340	             vName == null ? "viewfs:///" : ("viewfs://" + vName + "/"));
> 341	    }
> {code}
> The vName is always non-null due to checks/assignments done prior to this code segment.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message