hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Todd Lipcon (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-3970) BlockPoolSliceStorage#doRollback(..) should use BlockPoolSliceStorage instead of DataStorage to read prev version file.
Date Mon, 03 Dec 2012 23:31:58 GMT

    [ https://issues.apache.org/jira/browse/HDFS-3970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13509327#comment-13509327
] 

Todd Lipcon commented on HDFS-3970:
-----------------------------------

Hey Vinay. Sorry I missed the earlier upload.

Any chance you can add a test for this? I seem to remember it causing an easily-reproducible
bug where, after rollback, the DN wouldn't properly start due to the missing storageType field.
Am I remembering wrong? If that's the case, it should be easy to add a test.
                
> BlockPoolSliceStorage#doRollback(..) should use BlockPoolSliceStorage instead of DataStorage
to read prev version file.
> -----------------------------------------------------------------------------------------------------------------------
>
>                 Key: HDFS-3970
>                 URL: https://issues.apache.org/jira/browse/HDFS-3970
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: datanode
>    Affects Versions: 3.0.0, 2.0.2-alpha
>            Reporter: Vinay
>            Assignee: Vinay
>         Attachments: HDFS-3970.patch
>
>
> {code}    // read attributes out of the VERSION file of previous directory
>     DataStorage prevInfo = new DataStorage();
>     prevInfo.readPreviousVersionProperties(bpSd);{code}
> In the above code snippet BlockPoolSliceStorage instance should be used. other wise rollback
results in 'storageType' property missing which will not be there in initial VERSION file.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message