hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-4268) Remove redundant enum NNHAStatusHeartbeat.State
Date Thu, 06 Dec 2012 07:27:00 GMT

    [ https://issues.apache.org/jira/browse/HDFS-4268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13511184#comment-13511184
] 

Hudson commented on HDFS-4268:
------------------------------

Integrated in Hadoop-trunk-Commit #3090 (See [https://builds.apache.org/job/Hadoop-trunk-Commit/3090/])
    HDFS-4268. Remove redundant enum NNHAStatusHeartbeat.State. Contributed by Konstantin
Shvachko. (Revision 1417752)

     Result = SUCCESS
shv : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1417752
Files : 
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocolPB/PBHelper.java
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/BPOfferService.java
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/BackupState.java
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/protocol/NNHAStatusHeartbeat.java
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/TestBPOfferService.java
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/TestBlockRecovery.java

                
> Remove redundant enum NNHAStatusHeartbeat.State
> -----------------------------------------------
>
>                 Key: HDFS-4268
>                 URL: https://issues.apache.org/jira/browse/HDFS-4268
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: namenode
>    Affects Versions: 2.0.2-alpha
>            Reporter: Konstantin Shvachko
>            Assignee: Konstantin Shvachko
>         Attachments: heartbeatHAState.patch, heartbeatHAState.patch
>
>
> NNHAStatusHeartbeat.State is redundant and can be replaced with commonly used enum HAServiceState.
> We should also consistently use HAServiceState to check if the state is ACTIVE or STANDBY
rather than using {{instanceof}}.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message