Return-Path: X-Original-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id B28BED654 for ; Sun, 18 Nov 2012 22:04:59 +0000 (UTC) Received: (qmail 57271 invoked by uid 500); 18 Nov 2012 22:04:58 -0000 Delivered-To: apmail-hadoop-hdfs-issues-archive@hadoop.apache.org Received: (qmail 57222 invoked by uid 500); 18 Nov 2012 22:04:58 -0000 Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: hdfs-issues@hadoop.apache.org Delivered-To: mailing list hdfs-issues@hadoop.apache.org Received: (qmail 57147 invoked by uid 99); 18 Nov 2012 22:04:58 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 18 Nov 2012 22:04:58 +0000 Date: Sun, 18 Nov 2012 22:04:58 +0000 (UTC) From: "Tsz Wo (Nicholas), SZE (JIRA)" To: hdfs-issues@hadoop.apache.org Message-ID: <847317334.859.1353276298663.JavaMail.jiratomcat@arcas> In-Reply-To: <449174805.126842.1353119592110.JavaMail.jiratomcat@arcas> Subject: [jira] [Updated] (HDFS-4206) Change the fields in INode and its subclasses to private MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HDFS-4206?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tsz Wo (Nicholas), SZE updated HDFS-4206: ----------------------------------------- Resolution: Fixed Fix Version/s: 3.0.0 Hadoop Flags: Reviewed Status: Resolved (was: Patch Available) Suresh, thanks for reviewing the patch. I have committed this. > Change the fields in INode and its subclasses to private > -------------------------------------------------------- > > Key: HDFS-4206 > URL: https://issues.apache.org/jira/browse/HDFS-4206 > Project: Hadoop HDFS > Issue Type: Improvement > Components: name-node > Reporter: Tsz Wo (Nicholas), SZE > Assignee: Tsz Wo (Nicholas), SZE > Fix For: 3.0.0 > > Attachments: h4206_20121116b.patch, h4206_20121116.patch > > > The fields in INode and its subclasses are sometimes directly accessed and modified by other code. It is better to change them to private and use getters/setters. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira