Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Reply-To: hdfs-issues@hadoop.apache.org
Date: Fri, 9 Nov 2012 00:16:12 +0000 (UTC)
From: "Hadoop QA (JIRA)" <jira@apache.org>
To: hdfs-issues@hadoop.apache.org
Message-ID: <695875703.89556.1352420172643.JavaMail.jiratomcat@arcas>
In-Reply-To: <1509423395.76907.1352238253114.JavaMail.jiratomcat@arcas>
Subject: [jira] [Commented] (HDFS-4156) Seeking to a negative position
 should throw an IOE
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HDFS-4156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13493634#comment-13493634 ] 

Hadoop QA commented on HDFS-4156:
---------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12552723/HDFS-4156-2.patch
  against trunk revision .

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of javac compiler warnings.

    {color:green}+1 javadoc{color}.  The javadoc tool did not generate any warning messages.

    {color:green}+1 eclipse:eclipse{color}.  The patch built with eclipse:eclipse.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new Findbugs (version 1.3.9) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number of release audit warnings.

    {color:green}+1 core tests{color}.  The patch passed unit tests in hadoop-hdfs-project/hadoop-hdfs.

    {color:green}+1 contrib tests{color}.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/3468//testReport/
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/3468//console

This message is automatically generated.
                
> Seeking to a negative position should throw an IOE
> --------------------------------------------------
>
>                 Key: HDFS-4156
>                 URL: https://issues.apache.org/jira/browse/HDFS-4156
>             Project: Hadoop HDFS
>          Issue Type: Bug
>    Affects Versions: 1.0.0, 2.0.0-alpha
>            Reporter: Eli Collins
>              Labels: newbie
>         Attachments: HDFS-4156-1.patch, HDFS-4156-2.patch
>
>
> Credit to [~vanzin] for finding this. If you seek() to a position before the start of the file, the seek() call succeeds, and the following read() call throws an NPE. A more friendly approach would be to fail the seek() call.
> {noformat}
> Exception in thread "main" java.lang.NullPointerException
> at org.apache.hadoop.hdfs.DFSInputStream.readWithStrategy(DFSInputStream.java:670)
> at org.apache.hadoop.hdfs.DFSInputStream.read(DFSInputStream.java:685)
> at java.io.DataInputStream.read(DataInputStream.java:83)
> at fstest.main(fstest.java:12)
> {noformat}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira