Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Reply-To: hdfs-issues@hadoop.apache.org
Date: Tue, 13 Nov 2012 15:36:13 +0000 (UTC)
From: "Daryn Sharp (JIRA)" <jira@apache.org>
To: hdfs-issues@hadoop.apache.org
Message-ID: <1617660185.108221.1352820973242.JavaMail.jiratomcat@arcas>
In-Reply-To: <305115010.102932.1352755152896.JavaMail.jiratomcat@arcas>
Subject: [jira] [Updated] (HDFS-4181) LeaseManager tries to double remove
 and prints extra messages
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


     [ https://issues.apache.org/jira/browse/HDFS-4181?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Daryn Sharp updated HDFS-4181:
------------------------------

       Resolution: Fixed
    Fix Version/s: 0.23.5
                   2.0.3-alpha
                   3.0.0
     Hadoop Flags: Reviewed
           Status: Resolved  (was: Patch Available)

I've committed to trunk, branch 2 & 23.  Thanks Kihwal!
                
> LeaseManager tries to double remove and prints extra messages
> -------------------------------------------------------------
>
>                 Key: HDFS-4181
>                 URL: https://issues.apache.org/jira/browse/HDFS-4181
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: name-node
>    Affects Versions: 0.23.4, 2.0.2-alpha
>            Reporter: Kihwal Lee
>            Assignee: Kihwal Lee
>            Priority: Critical
>             Fix For: 3.0.0, 2.0.3-alpha, 0.23.5
>
>         Attachments: hdfs-4181-branch-0.23.patch, hdfs-4181-branch-0.23.patch, hdfs-4181-trunk.patch, hdfs-4181-trunk.patch
>
>
> When checkLeases() runs, internalReleaseLease() is called on the expired ones. When it returns true, the lease is already removed, yet it is tried again in checkLease(). This causes unnecessary ERROR messages to be logged. The line doing {{removing.add(p)}} should be removed.
> The internalReleaseLease() method logs a detailed message per call, so the extra INFO log message from checkLease() is redundant. 
> The error message from removeLease() can be very big and needs to be cut down. When the namenode itself is holding a lot of leases for block recovery, hitting this error is very expensive. In one instance, slow block recovery caused the namenode to hold more than 42K leases. The one log line in this case was over 4 MB.  The dump of data structure should be only enabled in debug mode.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira