Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Reply-To: hdfs-issues@hadoop.apache.org
Date: Fri, 30 Nov 2012 08:28:00 +0000 (UTC)
From: "Jing Zhao (JIRA)" <jira@apache.org>
To: hdfs-issues@hadoop.apache.org
Message-ID: <1422289386.44459.1354264080325.JavaMail.jiratomcat@arcas>
In-Reply-To: <1935555125.42572.1354227298542.JavaMail.jiratomcat@arcas>
Subject: [jira] [Updated] (HDFS-4243) INodeDirectory.replaceChild(..) does
 not update parent
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


     [ https://issues.apache.org/jira/browse/HDFS-4243?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jing Zhao updated HDFS-4243:
----------------------------

    Attachment: HDFS-4243.001.patch

Patch uploaded. The patch also refactors FSDirectory#replaceNode() by removing unnecessary FSNamesystem locking and rooDir.addINode() call.
                
> INodeDirectory.replaceChild(..) does not update parent
> ------------------------------------------------------
>
>                 Key: HDFS-4243
>                 URL: https://issues.apache.org/jira/browse/HDFS-4243
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: namenode
>            Reporter: Tsz Wo (Nicholas), SZE
>            Assignee: Jing Zhao
>         Attachments: HDFS-4243.001.patch
>
>
> The method replaces an existing child with a new child.  However, it does not take care the case the child also an INodeDirectory.  In such case, the parent pointers of the children of the child have to be updated to the new child.
> Only FSDirectory.unprotectedSetQuota(..) calls this method so that the child is always an INodeDirectory.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira