From hdfs-issues-return-52669-apmail-hadoop-hdfs-issues-archive=hadoop.apache.org@hadoop.apache.org Fri Nov 9 13:02:17 2012 Return-Path: X-Original-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 0BB59DFAB for ; Fri, 9 Nov 2012 13:02:17 +0000 (UTC) Received: (qmail 71237 invoked by uid 500); 9 Nov 2012 13:02:16 -0000 Delivered-To: apmail-hadoop-hdfs-issues-archive@hadoop.apache.org Received: (qmail 70863 invoked by uid 500); 9 Nov 2012 13:02:14 -0000 Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: hdfs-issues@hadoop.apache.org Delivered-To: mailing list hdfs-issues@hadoop.apache.org Received: (qmail 70808 invoked by uid 99); 9 Nov 2012 13:02:13 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 09 Nov 2012 13:02:13 +0000 Date: Fri, 9 Nov 2012 13:02:13 +0000 (UTC) From: "Hudson (JIRA)" To: hdfs-issues@hadoop.apache.org Message-ID: <184006492.91598.1352466133205.JavaMail.jiratomcat@arcas> In-Reply-To: <86674189.84732.1352338092146.JavaMail.jiratomcat@arcas> Subject: [jira] [Commented] (HDFS-4165) Faulty sanity check in FsDirectory.unprotectedSetQuota MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HDFS-4165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13493977#comment-13493977 ] Hudson commented on HDFS-4165: ------------------------------ Integrated in Hadoop-Hdfs-trunk #1221 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk/1221/]) HDFS-4165. Faulty sanity check in FsDirectory.unprotectedSetQuota. Contributed by Binglin Chang. (Revision 1407245) Result = SUCCESS suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1407245 Files : * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirectory.java > Faulty sanity check in FsDirectory.unprotectedSetQuota > ------------------------------------------------------ > > Key: HDFS-4165 > URL: https://issues.apache.org/jira/browse/HDFS-4165 > Project: Hadoop HDFS > Issue Type: Bug > Components: name-node > Affects Versions: 3.0.0 > Reporter: Binglin Chang > Assignee: Binglin Chang > Priority: Trivial > Fix For: 3.0.0 > > Attachments: HDFS-4165.patch > > > According to the documentation: > The quota can have three types of values : (1) 0 or more will set > the quota to that value, (2) {@link HdfsConstants#QUOTA_DONT_SET} implies > the quota will not be changed, and (3) {@link HdfsConstants#QUOTA_RESET} > implies the quota will be reset. Any other value is a runtime error. > sanity check in FsDirectory.unprotectedSetQuota should use > {code} > nsQuota != HdfsConstants.QUOTA_RESET > {code} > rather than > {code} > nsQuota < HdfsConstants.QUOTA_RESET > {code} > Since HdfsConstants.QUOTA_RESET is defined to be -1, there is not any problem for this code, but it is better to do it right. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira